celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
328 stars 267 forks source link

spec: update data_structures.md #3113

Open cmwaters opened 4 months ago

cmwaters commented 4 months ago

Many of our data structures have diverged from the spec such as the IndexWrapper which is the WrappedTransaction in the spec. We no longer have intermediate state roots and our blobs include new fields like the ShareVersion.

We need to comb through this part of the spec and try to update it with the current implementation.

I also have a slight preference to break down that file into smaller more parsable files if we can

rootulp commented 4 months ago

Agreed that the data structures contains a lot of names that don't match the implementation.

FWIW, I don't think this repo ever had intermediate state roots implemented so I think it was added to the specs because eventually we were planning on adding it but I agree we should remove it from the specs and add it to the specs if/when we implement it.