search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
347 stars 297 forks source link

Skip required fees for gentx #3271

Open rootulp opened 7 months ago

rootulp commented 7 months ago

Context

Problem

The addition of x/minfee made it required for gentx transactions to include a fee. I'm not sure if that was actually intentional.

Proposal

Explore the Cosmos Hub's minfee implementation. Apparently they skip required fees for the first block. If possible, apply something similar to our implementation.

rootulp commented 6 months ago

cc: @ninabarbakadze @cmwaters this caused setup pain for three separate issues so IMO we should at least discuss it.

evan-forbes commented 6 months ago

to close this issue, we can skip the minfee antehandler on block height 1. Technically this consensus breaking, if this more involved than an if statement, then we won't pursue this and just fix our tests. However, if it is that simple, then we will pursue this. cc @cmwaters to make sure you are aware as well.