search

celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
328 stars 260 forks source link

Dedicated feature branch for e2e benchmark tests with main branch sync #3371

Open staheri14 opened 2 months ago

staheri14 commented 2 months ago

In the Knuu e2e benchmark tests, we sometimes encounter the need to use versions of celestia-core that include unreleased breaking changes or features not fully integrated into celestia-app. This situation becomes a barrier to developing and merging benchmark tests into the celestia-app main branch. To address this issue, a decision has been made to establish a feature branch specifically for benchmark tests. Future PRs will be directed to this branch, facilitating seamless integrations without affecting the main branch of celestia-app.

Additionally, it would be useful to have an automated way to backport features from the main branch to this new feature branch, ensuring it remains up-to-date with the latest developments in the main.

evan-forbes commented 1 month ago

the goal is to merge this feature branch after v2

evan-forbes commented 1 month ago

we can unblock with https://github.com/celestiaorg/celestia-app/issues/3370

staheri14 commented 1 month ago

we can unblock with #3370

And https://github.com/celestiaorg/celestia-core/issues/1363