celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
341 stars 279 forks source link

GlobalMinGasPrice not getting persisted #3553

Closed ninabarbakadze closed 3 months ago

ninabarbakadze commented 3 months ago

Summary of Bug

Apparently, there is a problem persisting the app version and the GlobalMinGasPrice. I will continue digging.

celestia-appd tx blob pay-for-blob 0x00010203040506070809 0x000102030405060708094314314324324234234234234234234324234234234232 --fees 21000utia --chain-id 
private --keyring-backend test -b block --yes --from validator
code: 111222
codespace: undefined
data: ""
events: []
gas_used: "8786"
gas_wanted: "0"
height: "0"
info: ""
logs: []
raw_log: "recovered: parameter GlobalMinGasPrice not registered\ncaused by transaction:\n*types.MsgPayForBlobs{signer:\"celestia147x5c0hxx4vt7j8njx4s000vwut8vlxm7mz5ua\"
  namespaces:\"\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\000\\001\\002\\003\\004\\005\\006\\007\\010\\t\"
  blob_sizes:33 share_commitments:\"w3\\223!\\357\\222\\346$\\206\\022dp\\244ARt\\373\\\\\\356@\\266\\210\\\"\\206\\363\\212\\2430\\r\\224\\320\\366\"
  share_versions:0 }\n\nstack:\ngoroutine 468 [running]:\nruntime/debug.Stack()\n\t/Users/midnight/go/go1.22.3/src/runtime/debug/stack.go:24
  +0x64\ngithub.com/cosmos/cosmos-sdk/baseapp.newDefaultRecoveryMiddleware.func1({0x107789c80,
  0x14001665e70})\n\t/Users/midnight/go2/pkg/mod/github.com/celestiaorg/cosmos-sdk@v1.22.0-sdk-v0.46.16/baseapp/recovery.go:71
  +0x2c\ngithub.com/cosmos/cosmos-sdk/baseapp.newRecoveryMiddleware.func1({0x107789c80,
  0x14001665e70})\n\t/Users/midnight/go2/pkg/mod/github.com/celestiaorg/cosmos-sdk@v1.22.0-sdk-v0.46.16/baseapp/recovery.go:39
  +0x4c\ngithub.com/cosmos/cosmos-sdk/baseapp.processRecovery({0x107789c80, 0x14001665e70},
  0x1400023c780)\n\t/Users/midnight/go2/pkg/mod/github.com/celestiaorg/cosmos-sdk@v1.22.0-sdk-v0.46.16/baseapp/recovery.go:28
  +0x50\ngithub.com/cosmos/cosmos-sdk/baseapp.processRecovery({0x107789c80, 0x14001665e70},
  0x1400140d8a8)\n\t/Users/midnight/go2/pkg/mod/github.com/celestiaorg/cosmos-sdk@v1.22.0-sdk-v0.46.16/baseapp/recovery.go:33
  +0xb8\ngithub.com/cosmos/cosmos-sdk/baseapp.(*BaseApp).runTx

Version

2

Steps to Reproduce

  1. checkout v2.0.0-rc1
  2. bash scripts/single-node.sh
  3. let it run past block 3
  4. stop celestia-appd
  5. run it again using:
    celestia-appd start \
    --api.enable \
    --grpc.enable \
    --grpc-web.enable \
    --v2-upgrade-height 3
  6. execute:
    celestia-appd tx blob pay-for-blob 0x00010203040506070809 0x000102030405060708094314314324324234234234234234234324234234234232 --fees 21000utia --chain-id 
    private --keyring-backend test -b block --yes --from validator

Second one, if you do the above steps, and at step 5, remove the --v2-upgrade-height 3 flag, and execute the PFB command:

celestia-appd tx blob pay-for-blob 0x00010203040506070809 0x000102030405060708094314314324324234234234234234234324234234234232 --fees 21000utia --chain-id 
private --keyring-backend test -b block --yes --from validator
code: 37
codespace: sdk
data: ""
events: []
gas_used: "8786"
gas_wanted: "-1"
height: "0"
info: ""
logs: []
raw_log: 'app version 0 is not supported: feature not supported'
timestamp: ""
tx: null
txhash: C586BBD76F4AAFBFAD7064472A677AB8FC5D0E0429AFBBC29A05DB91550E2C35