search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 285 forks source link

Print a version of the app with the `version` sub command #357

Closed evan-forbes closed 2 years ago

evan-forbes commented 2 years ago

We are not properly registering a version for the version subcommand, so the command simply prints an empty line. We should change this to print the actual version, and ideally have some sort of CI test that ensures that we are actually using the correct version.

liamsi commented 2 years ago

I'm a bit confused about this issue. If the app should do sth different then the app would need to register its version (and not tendermint/core).

evan-forbes commented 2 years ago

😂 made this in the wrong repo

liamsi commented 2 years ago

I see. Let's move this to the app then :)

I think this can be fixed via the Makefile in app.

liamsi commented 2 years ago

Weird, we even use a version variable without ever defining it: https://github.com/celestiaorg/celestia-app/blob/56c82ec19c74a9a1e59dc4628124ef48f59ff3d1/Makefile#L63

mindstyle85 commented 2 years ago

if i remember correctly, in v0.2.0 you guys had that working already, just as fyi if it helps

liamsi commented 2 years ago

This is really weird. I'll create a quickfix shortly.

liamsi commented 2 years ago

https://github.com/celestiaorg/celestia-app/pull/360