search

celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
327 stars 261 forks source link

refactor(x/minfee)!: rename to network min gas price #3575

Closed rootulp closed 1 week ago

rootulp commented 1 week ago

Closes https://github.com/celestiaorg/celestia-app/issues/3568

Testing

Started a node and then:

$ celestia-appd query params subspace minfee NetworkMinGasPrice
key: NetworkMinGasPrice
subspace: minfee
value: '"0.000001000000000000"'
coderabbitai[bot] commented 1 week ago

[!WARNING]

Rate limit exceeded

@rootulp has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 56 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between b6134f8db132f20c7b6161cc9476e17bc556cf99 and 8a81a5334f938c14022a9cab904de403c65e212b.

Walkthrough

The changes primarily involve renaming the term "GlobalMinGasPrice" to "NetworkMinGasPrice" across various files and components of the application. This renaming impacts variable names, function names, comments, and parameter keys to reflect the new terminology accurately.

Changes

Files/Paths Change Summaries
app/ante/fee_checker.go Updated terminology from "global" to "network" for min fee.
app/ante/min_fee_test.go Renamed test function and variables from "GlobalMinGasPrice" to "NetworkMinGasPrice".
app/test/upgrade_test.go Renamed variable from GlobalMinGasPriceDec to NetworkMinGasPriceDec.
local_devnet/celestia-app/genesis.json Changed the key from "global_min_gas_price" to "network_min_gas_price".
pkg/appconsts/v2/app_consts.go Renamed GlobalMinGasPrice constant to NetworkMinGasPrice.
pkg/user/tx_client.go Updated function naming and internal logic to use "networkMinGasPrice" instead of "global".
proto/celestia/minfee/v1/genesis.proto Updated field name from global_min_gas_price to network_min_gas_price.
specs/src/specs/params.md, specs/src/.../resource_pricing.md Renamed references from global to network min gas price.
test/tokenfilter/setup.go Updated key from KeyGlobalMinGasPrice to KeyNetworkMinGasPrice.
x/minfee/README.md, x/minfee/genesis.go, x/minfee/module.go, x/minfee/params.go Renamed parameters and variables from GlobalMinGasPrice to NetworkMinGasPrice.
x/paramfilter/test/gov_params_test.go Updated test cases to reference "NetworkMinGasPrice".

Sequence Diagram(s)

No sequence diagram needed as changes involve renaming terminology with no modification to control flow or feature interactions.

Assessment against linked issues

Objective (Issue #) Addressed Explanation
Rename global min gas price to network min gas price (#3568) ✅

The code changes comprehensively address the renaming of "GlobalMinGasPrice" to "NetworkMinGasPrice" across all relevant files and components, aligning with the objective stated in the linked issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > :bangbang: **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.