search

celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
328 stars 261 forks source link

Flakiness in TestSquareSizeIntegrationTest #3585

Open staheri14 opened 1 week ago

staheri14 commented 1 week ago

Problem

TestSquareSizeIntegrationTest is flakey. Link to the logs.

--- FAIL: TestSquareSizeIntegrationTest (61.04s)
    square_size_test.go:46: setting up square size integration test
    --- FAIL: TestSquareSizeIntegrationTest/TestSquareSizeUpperBound (49.82s)
        --- FAIL: TestSquareSizeIntegrationTest/TestSquareSizeUpperBound/gov_square_size_==_hardcoded_max (16.26s)
            square_size_test.go:137: 
                    Error Trace:    /home/runner/work/celestia-app/celestia-app/app/test/square_size_test.go:1[37](https://github.com/celestiaorg/celestia-app/actions/runs/9569869274/job/26383358195?pr=3583#step:4:38)
                    Error:          Not equal: 
                                    expected: 128
                                    actual  : 64
                    Test:           TestSquareSizeIntegrationTest/TestSquareSizeUpperBound/gov_square_size_==_hardcoded_max
    network.go:46: tearing down testnode

Acceptance Criteria

staheri14 commented 1 week ago

Another instance of flakiness of this test https://github.com/celestiaorg/celestia-app/actions/runs/9584852073/job/26429395522?pr=3591