search

celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
328 stars 261 forks source link

feat!: reject MsgExec inside MsgExec #3590

Closed rootulp closed 3 days ago

rootulp commented 1 week ago

Closes https://github.com/celestiaorg/celestia-app/issues/3586

cc: @Reecepbcups

coderabbitai[bot] commented 1 week ago
Walkthrough ## Walkthrough A new method `hasNestedMsgExec` has been added to `MsgVersioningGateKeeper` in `msg_gatekeeper.go` to check for nested `MsgExec` messages and prevent them. The `hasInvalidMsg` method now uses this new function to forbid nested `MsgExec` messages. Corresponding test cases have also been updated to handle these new checks and version-specific message acceptance. ## Changes | Files | Change Summary | |---------------------------------------------|-----------------------------------------------------------------------------------------------------------------| | `app/ante/msg_gatekeeper.go` | Added `hasNestedMsgExec` method and updated `hasInvalidMsg` to include nested `MsgExec` checks. | | `app/ante/msg_gatekeeper_test.go` | Modified test cases to include nested `MsgExec` scenarios and updated initializations for better version checks.| ## Assessment against linked issues | Objective | Addressed | Explanation | |----------------------------------------------------------------------------------|-----------|----------------------------------------------------------------------------------------------| | Limit the recursion for message gatekeeper authz messages (Issue #3586) | ✅ | | | Ensure rejection of nested `MsgExec` messages in `hasInvalidMsg` function (#3586)| ✅ | |
Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 85eb1cb707448b29dd821b7a0f72fd652f6ce473 and 50bf790b295c16d73f1501ca38f3e36a628bb164.
Files selected for processing (2) * app/ante/msg_gatekeeper.go (2 hunks) * app/ante/msg_gatekeeper_test.go (1 hunks)
Additional comments not posted (4)
app/ante/msg_gatekeeper.go (2)
`52-57`: Add a comment explaining the version-specific behavior for nested `MsgExec`. This change successfully implements the logic to reject nested `MsgExec` messages for app version 2 and above. Consider adding a comment here to explain why this version-specific behavior is necessary, as it helps maintain clarity for future maintainers. --- `73-82`: Ensure comprehensive testing for `hasNestedMsgExec` method. The implementation of `hasNestedMsgExec` looks correct and aligns with the PR's objectives to prevent nested `MsgExec` messages. However, ensure that this method is thoroughly tested, especially considering different nesting scenarios and edge cases.
app/ante/msg_gatekeeper_test.go (2)
`19-38`: Update the test setup to reflect the new logic for nested `MsgExec`. The setup for the test cases has been appropriately adjusted to include a new variable `nestedMsgExec` and an updated `acceptedList` map. This setup is crucial for testing the new logic introduced in the `MsgVersioningGateKeeper`. --- `148-209`: Ensure `TestIsAllowed` covers all relevant cases. `TestIsAllowed` is a new function introduced to test message acceptance based on application versions. Make sure this function covers all relevant cases and accurately reflects the behavior defined in the `MsgVersioningGateKeeper`. This includes testing with messages that are not explicitly listed in the `acceptedList` to ensure they are correctly rejected.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > :bangbang: **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
rootulp commented 3 days ago

Closing this as won't do for now. Needs more investigation so created https://github.com/celestiaorg/celestia-app/issues/3609