Closed staheri14 closed 1 week ago
[!NOTE] Currently processing new changes in this PR. This may take a few minutes, please wait...
Commits
Files that changed from the base of the PR and between 85eb1cb707448b29dd821b7a0f72fd652f6ce473 and eb84b7f333364534c3ca2221523faec4a69db7f9.Files selected for processing (1)
* app/test/circuit_breaker_test.go (1 hunks)______________________________________________________ < Nothing is more permanent than a temporary solution. > ------------------------------------------------------ \ \ \ \ /\ ( ) .( o ).
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
👍 for posterity, how did this make it to main? just that we didn't force that the branch that was merged was up to date?
I am actually wondering about the same thing, how could it not be detected in the CIs
Looking back at the recent merged PRs, none seem to have experienced failure in the test
job (from test workflow) which is supposed to catch test failures.
I believe it was because of https://github.com/celestiaorg/celestia-app/pull/3555 which was an extra fix that resulted in changing the error message.
👍 for posterity, how did this make it to main? just that we didn't force that the branch that was merged was up to date?
Yea, if we want to never encounter test failures on main
then we should probably enforce that branches are always up to date with main
👍 for posterity, how did this make it to main? just that we didn't force that the branch that was merged was up to date?
Yea, if we want to never encounter test failures on
main
then we should probably enforce that branches are always up to date with main
Can we have a tracking issue to discuss it later in the calls?
An attempt to fix and close #3592
This is a quick attempt to correct the test by adjusting the expected outcomes of the last two assertions to match the actual result of
DeliverTx
for thenestedTx
. However, it may be necessary to update the test logic instead. cc: @rootulp @cmwaters