search

celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
328 stars 261 forks source link

Split WaitUntilStartedAndForwardPorts() into two funcs #3599

Open staheri14 opened 1 week ago

staheri14 commented 1 week ago 
          This can be done in a follow up but this function should really be two different functions since it performs two different actions.

In fact, I would be more in favour of grouping StartAsync and WaitInstanceIsRunning together

_Originally posted by @cmwaters in https://github.com/celestiaorg/celestia-app/pull/3515#discussion_r1646663199_