search

celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
328 stars 261 forks source link

chore(deps): upgrade to celestia-core v1.37.0-tm-v0.34.29 #3607

Closed rootulp closed 1 week ago

rootulp commented 1 week ago

Motivation: because celestia-core v1.37.0 uses NMT v0.21.0 which contains this fix: https://github.com/celestiaorg/nmt/pull/253

coderabbitai[bot] commented 1 week ago
Walkthrough ## Walkthrough The updates primarily focus on incrementing the version of Go from `1.22.3` to `1.22.4` across various configuration and manifest files, as well as dependency updates for some packages. This change ensures the use of the latest Go features and security updates within the project environment and dependencies. ## Changes | File/Path | Change Summary | |-----------------------------------------|-------------------------------------------------------------------------------------------------| | `Dockerfile` | Updated Go builder image to `golang:1.22.4-alpine3.19`. | | `Makefile` | Changed `GOLANG_CROSS_VERSION` from `v1.22.3` to `v1.22.4`. | | `README.md` | Updated Go installation instructions from version `1.22.3` to `1.22.4`. | | `go.mod` | Updated Go version to `1.22.4` and `tendermint` dependency. | | `go.work.example` | Changed Go version from `1.22.3` to `1.22.4`. | | `test/.../Dockerfile` | Updated `BUILD_BASE_IMAGE` to `golang:1.22.4-alpine3.19`. | | `test/.../compositions/standard/plan.toml` | Updated `build_base_image` and `go_version` to `1.22.4`. | | `test/.../go.mod` | Changed Go version to `1.22.4`, and updated `nmt` and `tendermint` dependencies. | | `test/.../manifest.toml` | Updated `build_base_image` and `go_version` to `1.22.4` for the `docker:generic` builder. |
Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between c8589614a6c8fd0b5808ddd802cf5d6578367860 and ad042c8734637d5f64249d2b411001cc072da30a.
Files ignored due to path filters (3) * `go.sum` is excluded by `!**/*.sum` * `test/interchain/go.sum` is excluded by `!**/*.sum` * `test/testground/go.sum` is excluded by `!**/*.sum`
Files selected for processing (10) * Dockerfile (1 hunks) * Makefile (1 hunks) * README.md (1 hunks) * go.mod (2 hunks) * go.work.example (1 hunks) * test/interchain/go.mod (3 hunks) * test/testground/Dockerfile (1 hunks) * test/testground/compositions/standard/plan.toml (1 hunks) * test/testground/go.mod (3 hunks) * test/testground/manifest.toml (1 hunks)
Files skipped from review due to trivial changes (9) * Dockerfile * Makefile * README.md * go.mod * go.work.example * test/interchain/go.mod * test/testground/compositions/standard/plan.toml * test/testground/go.mod * test/testground/manifest.toml
Additional context used
Hadolint
test/testground/Dockerfile
[warning] 17-17: Always tag the version of an image explicitly (DL3006) --- [info] 50-50: Use the `--no-cache` switch to avoid the need to use `--update` and remove `/var/cache/apk/*` when done installing packages (DL3019) --- [warning] 50-50: Pin versions in apk add. Instead of `apk add ` use `apk add =` (DL3018) --- [warning] 53-53: Use WORKDIR to switch to a directory (DL3003) --- [warning] 63-63: Use WORKDIR to switch to a directory (DL3003) --- [warning] 63-63: CgoEnabled is referenced but not assigned. (SC2154) --- [warning] 68-68: Use WORKDIR to switch to a directory (DL3003) --- [warning] 76-76: Always tag the version of an image explicitly (DL3006) --- [warning] 77-77: Pin versions in apk add. Instead of `apk add ` use `apk add =` (DL3018)
Additional comments not posted (1)
test/testground/Dockerfile (1)
Line range hint `77-77`: **Pin versions when installing packages.** It's best practice to pin the versions of packages when using `apk add` to ensure the build environment is predictable and consistent. [REFACTOR_SUGGESTion] ```diff - RUN apk add --no-cache bash gcompat curl + RUN apk add --no-cache bash=5.0.17 gcompat=1.0.0 curl=7.69.1 # Replace with the exact versions you need ```
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > :bangbang: **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.