search

celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
328 stars 261 forks source link

Extend the wait time for genesis nodes to produce the first block in e2e tests #3610

Closed staheri14 closed 4 days ago

staheri14 commented 1 week ago

Problem

In the e2e tests, we wait for a total of 1 second for the genesis nodes to progress to height 1, however, this amount is insufficient, given that block times are typically around 10 seconds and more. This causes the e2e benchmark tests fail to be initialized nondeterministically, specially for the big block tests, requiring to rerun the test multiple times.

Proposal

Proposal to change this wait time to 10 seconds.

rootulp commented 1 week ago

If this test is to mimic network conditions, why 10 seconds instead of ~12 seconds? Celestia block times are usually like ~11.8 seconds per https://www.mintscan.io/celestia/block/

If we don't need to mimic network conditions, why not make the block time much shorter like < 1 second?