search

celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
328 stars 261 forks source link

test: adding big block tests to the main branch #3612

Open staheri14 opened 1 week ago

staheri14 commented 1 week ago

Part of #3557 Closes https://github.com/celestiaorg/celestia-app/issues/3614 Closes #3638 Closes https://github.com/celestiaorg/celestia-app/issues/3371

coderabbitai[bot] commented 1 day ago

Walkthrough

The updates introduce new functionality and enhancements to the benchmark package of the e2e testing suite. Notable changes include the addition of the CheckResults method for result validation, new test case functions for various block sizes and latency scenarios, defined constants for data sizes, and modifications to existing configurations to use descriptive constants for gRPC message sizes. These changes aim to improve clarity, correctness, and overall benchmarking capabilities.

Changes

Files Change Summary
test/e2e/benchmark/benchmark.go Added new imports for context, appconsts, and testnode packages. Introduced CheckResults method in BenchmarkTest struct.
test/e2e/benchmark/main.go Added new test cases: TwoNodeBigBlock8MB, TwoNodeBigBlock32MB, TwoNodeBigBlock8MBLatency, TwoNodeBigBlock64MB, LargeNetworkBigBlock8MB, LargeNetworkBigBlock32MB, and LargeNetworkBigBlock64MB.
test/e2e/benchmark/manifest.go Added summary method to the Manifest struct to generate summary strings.
test/e2e/benchmark/throughput.go Added bigBlockManifest variable. Introduced several new functions for benchmark tests with different block sizes and network configurations.
test/e2e/testnet/defaults.go Introduced new constants for data size conversions (MB, GB, MiB, GiB) and updated existing TxsimVersion constant.
test/e2e/testnet/node.go Updated PullRoundStateTraces to PullBlockSummaryTraces, reflecting changes in log messages and event types.
test/e2e/testnet/setup.go Modified MakeConfig and MakeAppConfig functions to set certain values using appropriate constants.
test/e2e/testnet/testnet.go Added additional logging during the synchronization process of genesis nodes.
test/txsim/run.go Replaced hardcoded gRPC message sizes with constants for better clarity.

Assessment against linked issues

Objective Addressed Explanation
Clarifying unit of grpcMaxRecvMsgSize/SendMsgSize (#3614) ✅
Improve E2E Benchmark Test Correctness Verification to Avoid False Positives (#3638) ✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > :bangbang: **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
staheri14 commented 1 day ago

The markdown linter issue should be resolved by #3639

staheri14 commented 1 day ago

I have tested all the benchmark tests in this branch. However, I made a few recent changes (a few hours ago) that I am still re-running tests for them to ensure they haven't caused any regression. I will mark the PR as a draft, but any early review is welcome!