Consider explicitly specifying benchmarks instead of defaulting to all

celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk

https://celestia.org

Apache License 2.0

328 stars 261 forks source link

Consider explicitly specifying benchmarks instead of defaulting to all #3617

Closed staheri14 closed 3 days ago

staheri14 commented 4 days ago

          👍

Personally I don't think we should default run all benchmarks. Unlike the correctness e2e tests, I think which benchmarks to run should always be explicitly specified. It doesn't really matter at the moment when we just have a single benchmark

Originally posted by @cmwaters in https://github.com/celestiaorg/celestia-app/pull/3595#pullrequestreview-2130355427