Specs inconsistencies

[rootulp]

Context

https://celestiaorg.github.io/celestia-app/

Problems

• availableDataHeader and availableData are used in the specs but they don't exist in the implementation.
• The Data Structures page is enormous. Consider splitting it into multiple pages.
• Some diagrams and constants reference ISRs (intermediate state roots) which don't exist in the implementation. If we do this, also remove "Length of availableData.intermediateStateRootData..."
• These are never used https://celestiaorg.github.io/celestia-app/specs/consensus.html#units
• TARGET_ANNUAL_ISSUANCE is wrong
• availableDataOriginalSquareSize doesn't match a name used in the implementation
• AVAILABLE_DATA_ORIGINAL_SQUARE_TARGET doesn't exist
• "Note that transactions mutate the state (essentially, the validator set and minimal balances)" => drop the word minimal
• https://celestiaorg.github.io/celestia-app/specs/consensus.html#blockavailabledatatransactiondata
  • remove the tips
  • remove the validator queue
  • remove the blob paid list
• Remove https://celestiaorg.github.io/celestia-app/specs/consensus.html#signedtransactiondatatransfer
• https://celestiaorg.github.io/celestia-app/specs/consensus.html#signedtransactiondatamsgpayfordata
  • remove tip rate
  • remove blobPaidListInsert(tx, id(tx))
• https://celestiaorg.github.io/celestia-app/specs/consensus.html#begin-block block rewards go to all voting power not just the current block proposer
• Page headings should match the page title and the name used in the sidebar.
• https://celestiaorg.github.io/celestia-app/specs/block_proposer.html#honest-block-proposer the block size is enforced through consensus rules in process_proposal.go
• IMO https://celestiaorg.github.io/celestia-app/specs/fraud_proofs.html#blob-inclusion should be Blob Inclusion Fraud Proofs
• IMO https://celestiaorg.github.io/celestia-app/specs/fraud_proofs.html#state should be State Fraud Proofs
• https://celestiaorg.github.io/celestia-app/specs/networking.html#msgwirepayfordata commitmentrules => commitment rules
• It's pretty confusing that the Networking page has more data types and fraud proofs. Can the fraud proofs be moved to the Fraud Proofs page and the data structures be moved under the data structures page?

[rootulp]

Two more ideas:

1. Make "Honest Block Proposer" title consistent with the page title "Block Proposer".
2. Consider reordering all items in the summary that are app version specific to one group.

[rootulp]

One more idea:

• Constants have inconsistent casing. Proposal for all the constants in the specs to match the name and casing of the Go implementation.