celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
337 stars 275 forks source link

Confusion between ODS and EDS when proving a share range #3760

Open rach-id opened 1 month ago

rach-id commented 1 month ago

Currently, we provide the API to prove a share range:

https://github.com/celestiaorg/celestia-app/blob/4f4d0f7ff1a43b62b232726e52d1793616423df7/pkg/proof/proof.go#L59-L73

The problem with this implementation is that it doesn't make the distinction between the ODS and the EDS. This creates the following confusion.

Given the following square:

image

Moreover, while discussing the proofs, it will be good to extend the functionality of proof generation to support multiple namespaces per proof. But this can be left for a subsequent discussion.

Update: the API proves the ODS shares, which means that we're not providing the full API for Blobstream.

rach-id commented 1 month ago

Sync decision: instead of making code changes, we can just update the documentation everywhere to match the current API. And if there is demand for the improvements, we can discuss them then.