celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
337 stars 278 forks source link

ICA AllowMessages on Arabica is incorrect #3824

Closed rootulp closed 2 weeks ago

rootulp commented 3 weeks ago

Problem

On Arabica, the ICA host AllowMessages param is incorrect. It is currently a wildcard when it should be an allowlist of messages:

root@rootulp-arabica:~# celestia-appd query params subspace icahost AllowMessages
key: AllowMessages
subspace: icahost
value: '["*"]'

Wildcard is the default however it should've been overwritten with this list: https://github.com/celestiaorg/celestia-app/blob/2f74d9b84353b714295d3179b6df6c8315ffb813/app/ica_host.go#L3-L18

rootulp commented 3 weeks ago

On Arabica and Mocha we can use governance to modify it but we should fix the override so that it doesn't need a governance vote on mainnet.

rootulp commented 3 weeks ago

https://github.com/celestiaorg/celestia-app/pull/3182 was added before the module manager. Notably the module manager uses https://github.com/celestiaorg/celestia-app/blob/2f74d9b84353b714295d3179b6df6c8315ffb813/app/modules.go#L186 which does not have an overwritten default genesis state. The default genesis state was only overwritten for the app module basic.

rootulp commented 3 weeks ago

Please see meeting notes and hackMD doc for full details.

Summary:

rootulp commented 2 weeks ago

We're tackling this with three solutions:

  1. https://github.com/celestiaorg/celestia-app/issues/3827
  2. https://github.com/celestiaorg/celestia-app/issues/3836
  3. https://github.com/celestiaorg/celestia-app/issues/3837