search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
346 stars 293 forks source link

Make `icahost.AllowMessages` unmodifiable by governance #3837

Open rootulp opened 2 months ago

rootulp commented 2 months ago

Context

https://github.com/celestiaorg/celestia-app/issues/3824

Problem

Arabica and Mocha have an incorrect ICA host param for AllowMessages because it is the default [*]. It should be an explicit allowlist.

Proposal

Make icahost.AllowMessages unmodifiable by governance. Hard-code it to the explicit allowlist defined in https://github.com/celestiaorg/CIPs/blob/main/cips/cip-14.md

rootulp commented 2 months ago

We may not want to do this if we frequently get requests from teams to update the list because making the param unmodifiable by governance means that the list can only be modified via app version upgrades.

evan-forbes commented 2 months ago

per sync

it doesn't appear that pfbs can be submitted via ICA, therefore we don't need to block PFBs, and governance can be responsible for picking the values

if this changes, then we can reevaluate, until this is deprioritized

rootulp commented 2 months ago

Related: https://github.com/celestiaorg/celestia-app/issues/3857 we can get more visibility on the error with PFBs if we bump ibc-go