celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

chore: upgrade to Go 1.23.1 #3848

Closed rootulp closed 1 month ago

rootulp commented 2 months ago

Description

Upgrade to Go 1.23.1 motivated by https://github.com/celestiaorg/celestia-app/pull/3847. I had to modify GoReleaser config because https://github.com/goreleaser/goreleaser/issues/5127.

Maintainers need to update their local golangic-lint binary to v1.61.0. See golangci-lint install.

coderabbitai[bot] commented 2 months ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough This pull request includes updates to various configuration files and dependencies in the project. Key changes involve upgrading the versions of tools such as `golangci-lint`, Go itself, and Docker images, as well as modifications to linting configurations and documentation files to ensure up-to-date information regarding dependencies. ## Changes | File | Change Summary | |---------------------------------------|---------------------------------------------------------------------------------------------------------| | `.github/workflows/lint.yml` | Updated `golangci-lint-action` version from `v1.59.1` to `v1.61.0`, adjusted `PATTERNS`, and removed `skip-pkg-cache`. | | `Makefile` | Changed `GOLANG_CROSS_VERSION` from `v1.22.6` to `v1.23.1` and added a comment about verifying Docker images. | | `README.md` | Updated Go version from `1.22.6` to `1.23.1` and `golangci-lint` version from `1.59.1` to `1.61.0`, clarified installation instructions, and refined contributing guidelines. | | `docker/Dockerfile` | Updated `BUILDER_IMAGE` from `docker.io/golang:1.22.6-alpine3.19` to `docker.io/golang:1.23.1-alpine3.20`. | | `docker/txsim/Dockerfile` | Updated base image from `golang:1.22.6-alpine3.19` to `golang:1.23.1-alpine3.20`. | | `go.mod` | Updated Go version to `1.23.1`, modified several dependencies, and added replace directives. | ## Possibly related PRs - **#3607**: This PR updates the `Dockerfile` to a newer version of the Golang builder image, which is relevant to the changes in the main PR that also involve updates to Dockerfiles and Go versions. - **#3659**: Similar to the main PR, this PR updates the `go.mod` file to reflect a newer version of the `tendermint` dependency, which aligns with the version updates in the main PR. - **#3902**: This PR modifies the `.github/workflows/lint.yml` file by adding a new input parameter for the `hadolint` job, which is directly related to the changes made in the main PR that also involve modifications to the same linting workflow file. ## Suggested labels `backport:v1.x`, `backport:v2.x`, `external`

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
rootulp commented 2 months ago

There's a bug in Go 1.23 https://github.com/golang/go/issues/69312 that is impacting celestia-node so let's hold off on merging this until we identify if the same issue may hit us.

rootulp commented 1 month ago

Looks like https://github.com/golang/go/issues/69312 was fixed in Go 1.23.2. celestia-app doesn't invoke timer.Stop so I think we can proceed with this Go bump.