celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

Remove the evidence module in v4 #3889

Open ninabarbakadze opened 2 months ago

ninabarbakadze commented 2 months ago

Description

After writing AppHash test we realised that we have a msg MsgSubmitEvidence that's not used and should probably be disabled in v3

rootulp commented 2 months ago

Can you elaborate on how/why it's not used? It looks like it's part of the x/evidence module still: https://github.com/celestiaorg/cosmos-sdk/blob/release/v0.46.x-celestia/x/evidence/spec/03_messages.md#msgsubmitevidence

rootulp commented 1 month ago

Additional context from in-person sync:

tac0turtle commented 1 month ago

by removing evidence you allow validators to double sign with no repercussion: https://github.com/cosmos/cosmos-sdk/blob/fc91e76354512e8538f9da5bc9d3518f54921417/x/evidence/keeper/abci.go#L28. Is this desired?