celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

Refactor e2e tests to improve structure and reduce argument count #3907

Open mojtaba-esk opened 1 month ago

mojtaba-esk commented 1 month ago

The current e2e test setup could be improved by refactoring to enhance code readability and maintainability. Specifically, several functions have an excessive number of arguments, which can be streamlined using options or by passing relevant structs. Additionally, passing the *knuu.Knuu struct to the testnet constructor would be a cleaner approach. This issue aims to address these points by refactoring the test suite to make it more idiomatic and manageable.

Originally posted by @cmwaters in https://github.com/celestiaorg/celestia-app/pull/3900#pullrequestreview-2325619673