search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

chore: update e2e tests to knuu 0.16.1 #3911

Closed mojtaba-esk closed 1 month ago

mojtaba-esk commented 1 month ago

This PR proposes updating the e2e tests code to use the latest version of knuu (v0.16.1)

The main changes of this release are:

  1. Use unique static names for instances: now knuu does not add a random string to the names of the instances to make them predictable; therefore, it paves the path to the long running tests.
  2. CTRL+C to run timeout handler with no sleep: optimizes the termination request by the user
  3. Ability to fetch logs from instances
  4. Adjust stopped status actions for the update image: From now on, user can Stop the instance, then update the image, arguments, start command and or env vars, then commit and start the instance. This is handy for upgrade test.

BTW: the e2e tests are passing locally.

coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough
📝 Walkthrough ## Walkthrough This pull request includes significant updates to the `go.mod` file, modifying dependency versions and removing several indirect dependencies. Additionally, it refactors multiple test files, enhancing variable declarations and simplifying context management in the `MajorUpgradeToV2` and `MinorVersionCompatibility` functions. The `Upgrade` method in the `Node` struct has been restructured to ensure a proper stop-start sequence during Docker image upgrades. Logging enhancements and clearer preloader instantiation have also been implemented in the `Testnet` struct. ## Changes | File Path | Change Summary | |------------------------------------|----------------------------------------------------------------------------------------------------| | `go.mod` | Updated versions for several dependencies and removed multiple indirect dependencies. | | `test/e2e/major_upgrade_v2.go` | Refactored `MajorUpgradeToV2` function with improved variable declarations and context handling. | | `test/e2e/minor_version_compatibility.go` | Simplified context management and variable initialization in `MinorVersionCompatibility`. | | `test/e2e/simple.go` | Introduced cancellation context for lifecycle management in `E2ESimple` function. | | `test/e2e/testnet/node.go` | Modified `Upgrade` method to include a stop-start sequence for Docker image upgrades. | | `test/e2e/testnet/testnet.go` | Enhanced logging in `New` function and clarified preloader instantiation in `NewPreloader`. | ## Possibly related PRs - **#3487**: Modifies the `MajorUpgradeToV2` function in `test/e2e/major_upgrade_v2.go`, related to the main PR's dependency updates. - **#3556**: Updates the `MajorUpgradeToV2` function to include node restart functionality during upgrades, relevant to the upgrade process indicated in the main PR. - **#3607**: Changes in the `go.mod` file for upgrading dependencies are directly related to the main PR's focus on updating various dependencies. - **#3873**: Involves migrating tests to the new Knuu framework, which may include dependencies updated in the main PR, ensuring compatibility with the latest versions. - **#3924**: Addresses code quality in files that may interact with the dependencies updated in the main PR. ## Suggested labels `knuu`, `WS: Maintenance 🔧` ## Suggested reviewers - staheri14 - cmwaters - evan-forbes - rootulp

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.