'exportloopref' is deprecated

celestiaorg / celestia-app

Celestia consensus node

https://celestiaorg.github.io/celestia-app/

Apache License 2.0

345 stars 292 forks source link

'exportloopref' is deprecated #3918

Closed rootulp closed 1 month ago

rootulp commented 1 month ago

Problem

On v2.x

$ make lint
--> Running golangci-lint
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.

Proposal

Resolve the warning

tusharnagar17 commented 1 month ago

Hi team, I'm interested in working on this issue. Could you please assign it to me?

kobakaku commented 1 month ago

I've done this issue. This issue needs to address the new lint errors.

rootulp commented 1 month ago

Looks resolved to me on v2.x:

$ make lint
--> Running golangci-lint
--> Running markdownlint
--> Running hadolint
--> Running yamllint