fix(lint): golang-client lint errors

[kobakaku]

Closes https://github.com/celestiaorg/celestia-app/issues/3919

Overview

Fix the lint errors of golangci-lint. Merge this PR to this branch.

[coderabbitai[bot]]

📝 Walkthrough

## Walkthrough The pull request introduces several changes across multiple files, primarily focusing on updating linter configurations, enhancing test coverage, and improving error handling. Key modifications include the removal of deprecated linters, the addition of new test cases for transaction prioritization and data availability headers, and adjustments to error message formatting in the keeper package. ## Changes | File Path | Change Summary | |---------------------------------------------|---------------------------------------------------------------------------------------------------| | `.golangci.yml` | Removed `exportloopref`, added `copyloopvar`, and set `max-func-lines` for `nakedret` to 0. | | `app/test/priority_test.go` | Implemented a test suite for transaction prioritization by gas price with several helper methods. | | `pkg/da/data_availability_header_test.go` | Added tests for `DataAvailabilityHeader`, enhancing coverage for edge cases and error handling. | | `x/blob/client/testutil/integration_test.go` | Introduced a test suite for blob transactions with multiple test cases covering various scenarios. | | `x/blobstream/keeper/keeper_data_commitment.go` | Improved error handling by simplifying error message formatting. | | `x/blobstream/keeper/keeper_valset_test.go` | Added new test cases for validation set and attestation nonce handling, enhancing test robustness. | | `x/mint/client/testutil/suite_test.go` | Removed unnecessary variable shadowing in test methods for clarity. | | `x/mint/simulation/decoder_test.go` | Simplified `TestDecodeStore` by removing unnecessary variable reassignment. | ## Assessment against linked issues | Objective | Addressed | Explanation | |------------------------------------------------------------------|-----------|-------------------------------------------------| | Address lint complaints regarding non-constant format strings ( #3919) | ✅ | | ## Possibly related PRs - **#3450**: Changes in the main PR regarding the `.golangci.yml` configuration file may relate to modifications in the `app/export.go` file. - **#3735**: Refactor regarding gas scheduler variables may connect to the stricter enforcement of linter rules. - **#3902**: Restructuring of Dockerfile paths aligns with the goal of improving project organization. ## Suggested labels `bug`, `testing`

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[rootulp]

Added backport to v2.x label b/c I originally noticed these lint issues were on v2.x branch.