celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

Prebuilt binaries don't get attached for `-arabica` or `-mocha` tag #3926

Closed rootulp closed 1 month ago

rootulp commented 1 month ago

Context

We recently shifted to creating -arabica, -mocha tags for each release.

https://github.com/celestiaorg/celestia-app/blob/363a8c5a81bddcd9a4c88a7ee8c9f2516e1c36a6/.github/workflows/goreleaser.yml#L42-L43

https://github.com/celestiaorg/celestia-app/blob/363a8c5a81bddcd9a4c88a7ee8c9f2516e1c36a6/.goreleaser.yaml#L120-L121

Problem

GoReleaser didn't attach prebuilt binaries to:

GoReleaser thinks the latest tag is v2.2.0-rc0 instead of v2.2.0-arabica or v2.2.0-mocha. See https://github.com/celestiaorg/celestia-app/actions/runs/11020450957/job/30605337119#step:6:99

Proposal

Fix GoReleaser config so that it can attach prebuilt binaries to these releases. A few tips:

  1. Ask questions in GoReleaser Discord or submit a GH issue with details
  2. Investigate the prerelease_suffix