celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

v2.2.0-mocha Docker image does not exist #3934

Closed rootulp closed 1 month ago

rootulp commented 1 month ago

Context

https://github.com/celestiaorg/celestia-app/pkgs/container/celestia-app/versions

Reported by @smuu

Problem

A docker image for v2.2.0-mocha does not exist

Proposal

MSevey commented 1 month ago

I know the team uses feature branches a lot. Did all my fixes get applied to the correct feature branches?

I'm going to assume no, as I don't see a v2.2.0-mocha trigger in the actions https://github.com/celestiaorg/celestia-app/actions/workflows/docker-build-publish.yml

MSevey commented 1 month ago

If the tag was built off of the v2.x branch then the issue is that branch doesn't contain the CI fixes.

https://github.com/celestiaorg/celestia-app/blob/v2.x/.github/workflows/docker-build-publish.yml

rootulp commented 1 month ago

Yes the tag was built off of the v2.x branch. I'll update it to account for your fixes.

rootulp commented 1 month ago

Manually triggered https://github.com/celestiaorg/celestia-app/actions/runs/11146831921

Update: the manual trigger won't work because the Dockerfile in v2.2.0-mocha isn't where main expects it to be.

MSevey commented 1 month ago

You need to select the v2 branch when you manually trigger the action for v2 updates

Screenshot 2024-10-02 at 11 46 37 AM
rootulp commented 1 month ago

Manually published https://github.com/celestiaorg/celestia-app/pkgs/container/celestia-app/283797346?tag=v2.2.0-mocha