celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

feat: limit the number of messages in prepare proposal #3942

Closed rach-id closed 1 month ago

rach-id commented 1 month ago

This PR limits the number of transactions in prepare proposal.

coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes in this pull request enhance the testing framework and transaction filtering logic within the application. New test functions are introduced to validate transaction limits for different transaction types, while existing functions are modified to enforce caps on specific transactions. Additionally, new constants are added to define these limits, improving the overall configuration of transaction handling. ## Changes | File Path | Change Summary | |------------------------------------|----------------------------------------------------------------------------------------------------| | app/test/prepare_proposal_test.go | Added new test functions `TestPrepareProposalCappingNumberOfTransactions` and `TestPrepareProposalCappingNumberOfMessages` for transaction limit tests. | | app/validate_txs.go | Updated `filterStdTxs` and `filterBlobTxs` functions to enforce transaction limits and added `countOccurrence` helper function. | | pkg/appconsts/global_consts.go | Added constants `NonPFBTransactionCap` and `PFBTransactionCap` for transaction limits. | | pkg/appconsts/v3/app_consts.go | Introduced constants `MsgSendTransactionCap` (3200), `SdkMsgTransactionCap` (200), and `PFBTransactionCap` (600) for transaction limits. | | Makefile | Modified `test-race` target to include a timeout parameter for test execution. | ## Possibly related PRs - **#3909**: This PR introduces new test cases in `app/test/prepare_proposal_test.go` that validate the behavior of the `PrepareProposal` function when handling oversized transactions, which directly relates to the enhancements made in the main PR regarding transaction capping. - **#3967**: This PR modifies `app/test/prepare_proposal_test.go` to update comments and variable names reflecting the shift from "MaxTxBytes" to "MaxTxSize," aligning with the changes in the main PR that also focus on capping transaction sizes. ## Suggested labels `testing`, `WS: Big Blonks 🔭`, `optimization`, `WS: Maintenance 🔧` ## Suggested reviewers - evan-forbes - ninabarbakadze - rootulp - cmwaters

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
rach-id commented 1 month ago

One extra test case for transactions with multiple messages

c5071a3a3aaa8eea231492f1398123492b195508

rach-id commented 1 month ago

https://github.com/celestiaorg/celestia-app/issues/3972