search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

chore: optimize checkTx #3954

Closed evan-forbes closed 1 month ago

evan-forbes commented 1 month ago

Overview

this PR makes a simple optimization for checkTx

coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The pull request introduces significant modifications to transaction context handling within the `ProcessProposal` method. A new variable `ctx` is utilized in place of `sdkCtx`, affecting transaction processing and validation. Additionally, tests are enhanced to cover edge cases, particularly involving blob transactions that exceed share limits. The changes also involve updates to the `BlobShareDecorator` for accurate share calculations based on transaction size. Overall, the updates maintain existing logic while improving context management and test coverage. ## Changes | File | Change Summary | |----------------------------------------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | app/process_proposal.go | Modified `ProcessProposal` method to use `ctx` instead of `sdkCtx` for transaction processing and validation. Added a check for transaction bytes with `sdkCtx.WithTxBytes(tx)` (commented out). Maintained existing transaction logic. | | app/test/prepare_proposal_test.go | Enhanced `TestPrepareProposalFiltering` by adding a test for blob transactions exceeding share limits. Introduced utility function `repeat` for generating slices. | | app/test/process_proposal_test.go | Updated `TestProcessProposal` with a new test case for blob transactions that exceed share limits. Added import for `v3` application constants. | | x/blob/ante/blob_share_decorator.go | Altered `BlobShareDecorator`'s `AnteHandle` method and `getSharesNeeded` function to include transaction size in share calculations. Updated method signature for `getSharesNeeded`. | | x/blob/ante/blob_share_decorator_test.go| Updated `TestBlobShareDecorator` to use `blobsPerPFB` and `blobSize` for clearer test case definitions. Modified test setup to utilize a new signer and adjusted blob transaction handling. Updated `repeat` function to be generified. | ## Possibly related PRs - **#3513**: This PR's updates to the `process_proposal_test.go` file align with the main PR's modifications to the `ProcessProposal` method, indicating a direct relationship in testing transaction proposals. - **#3879**: The updates in `app/test/consistent_apphash_test.go` involve testing the consistency of application hashes across different versions, which relates to the transaction processing logic refined in the main PR. - **#3735**: The changes in `app/ante/ante.go` and related files introduce version-aware gas scheduling, which could impact transaction processing and validation, linking it to the context management changes in the main PR. - **#3910**: The end-to-end upgrade tests for version 3 involve transaction processing, which is relevant to the changes made in the main PR regarding transaction context management and validation logic. ## Suggested reviewers - ninabarbakadze - rootulp - cmwaters - staheri14
📜 Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between bc2614301bc094db27fb7d6ba021fbd944a44067 and c2f050dfa7c01713a3b855508745258743698599.
📒 Files selected for processing (1) * app/process_proposal.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * app/process_proposal.go
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
evan-forbes commented 1 month ago

for posterity, this is the PR that is being backported to v2, therefore, its a non-breaking version. ontop of this PR for v3, a breaking change can be made by uncommenting out the ctx change in process proposal

edit: ref https://github.com/celestiaorg/celestia-app/pull/3960