search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

`TestOfferSnapshot/should_ACCEPT_a_snapshot_with_app_version_1 ` flake #3956

Closed rootulp closed 1 month ago

rootulp commented 1 month ago

Context

https://github.com/celestiaorg/celestia-app/actions/runs/11261875155/job/31316284323?pr=3955#step:4:212

Problem

--- FAIL: TestOfferSnapshot (0.04s)
    --- FAIL: TestOfferSnapshot/should_ACCEPT_a_snapshot_with_app_version_1 (0.01s)
        testing.go:1232: TempDir RemoveAll cleanup: unlinkat /tmp/TestOfferSnapshotshould_ACCEPT_a_snapshot_with_app_version_11917707376/001/data/snapshots/1771500: directory not empty
FAIL

Proposal

FIx the test so it isn't flaky