search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

feat: increase default mempool `TTLNumBlocks` to 12 #3961

Closed rootulp closed 1 month ago

rootulp commented 1 month ago

Motivation in the Mempool TTL duration section of https://github.com/celestiaorg/celestia-app/issues/3959#issuecomment-2405769487

Description

Modify the default consensus node config for mempools so that:

Testing

make install && ./scripts/single-node.sh then cat the config

version = "v1"
ttl-duration = "1m15s"
ttl-num-blocks = 12
coderabbitai[bot] commented 1 month ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes involve modifications to the `app/default_overrides.go` and `app/default_overrides_test.go` files. The `default_overrides.go` file introduces a new constant for mebibyte and updates the default genesis states for several modules, particularly enhancing parameters in the `slashingModule`. The `DefaultConsensusConfig` function has also been revised to adjust transaction limits and durations. Correspondingly, the `default_overrides_test.go` file has been updated to reflect these changes in the test cases, ensuring that the new configurations are validated correctly. ## Changes | File | Change Summary | |-------------------------------|----------------------------------------------------------------------------------------------------| | app/default_overrides.go | - Added constant `mebibyte = 1024 * 1024`.
- Updated `DefaultGenesis` methods for multiple modules.
- Revised `DefaultConsensusConfig` with new values for `TTLNumBlocks`, `TTLDuration`, `MaxTxBytes`, and `MaxTxsBytes`.
- Removed commented-out code regarding mempool upper bound bytes. | | app/default_overrides_test.go | - Modified `TestDefaultConsensusConfig` to validate new values for `MaxTxBytes`, `MaxTxsBytes`, `TTLNumBlocks`, and `TTLDuration`. | ## Possibly related PRs - **#3967**: The changes in this PR involve renaming `MaxTxBytes` to `MaxTxSize`, which directly relates to the modifications in the main PR that define `MaxTxBytes` as `8 * mebibyte` and `40 * mebibyte`. Both PRs address transaction size configurations, indicating a strong connection at the code level. ## Suggested reviewers - liamsi - staheri14 - evan-forbes - ninabarbakadze

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
rootulp commented 1 month ago

I would slightly prefer to increase to 8MB which can path the way for increases in the cap when they come (which we will want them to).

This PR doesn't modify MaxTxBytes and IMO that should be discussed separately. Agreed that we may want to change it based on the recently added tx size antehandler.

The motivation for this PR is to update constants based on the decrease of block time from 12 to 6 seconds (https://github.com/celestiaorg/celestia-app/issues/3959#issue-2578922762). Specifically, prior to this change, the mempool would evict transactions that are either 1m 15 seconds old or 6 blocks (i.e. 6 11.77 seconds = 70.62 seconds) old. After the block time reduction, transactions will be evicted from the mempool after 6 6 seconds = 36 seconds. If we want to retain existing mempool behavior, we should bump the TTLNumBlocks.

rootulp commented 1 month ago

Based on what you're saying why not just have a TTL based on time only (rather than num blocks)

We could. I supposed that's a breaking change to end-users but we can consider removing the TTL num blocks feature.