search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

refactor: cap tx size flups #3967

Closed ninabarbakadze closed 1 month ago

ninabarbakadze commented 1 month ago

Overview

github-actions[bot] commented 1 month ago

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://celestiaorg.github.io/celestia-app/pr-preview/pr-3967/ on branch gh-pages at 2024-10-11 17:51 UTC

coderabbitai[bot] commented 1 month ago
📝 Walkthrough ## Walkthrough The changes in this pull request involve renaming the transaction size constant from `MaxTxBytes` to `MaxTxSize` across multiple files, including the main application logic, test cases, and documentation. This update affects how the maximum transaction size is referenced and validated in the application, ensuring consistency in terminology. The modifications include changes to method names, variable names, and test case assertions, while the overall logic and structure of the affected methods and tests remain unchanged. ## Changes | File | Change Summary | |---------------------------------------|-------------------------------------------------------------------------------------------------| | app/ante/max_tx_size.go | Renamed variable `maxTxBytes` to `maxTxSize` in `AnteHandle` method to reflect new constant. | | app/ante/max_tx_size_test.go | Updated test cases in `TestMaxTxSizeDecorator` to use `MaxTxSize` instead of `MaxTxBytes`. | | app/test/prepare_proposal_test.go | Updated comments and variable names in `TestPrepareProposalFiltering` to reflect `MaxTxSize`. | | app/test/process_proposal_test.go | Updated comments and variable names in `TestProcessProposal` to reflect `MaxTxSize`. | | app/validate_txs.go | Removed setting of transaction bytes in context in `filterStdTxs` and `filterBlobTxs` functions. | | pkg/appconsts/v3/app_consts.go | Renamed constant `MaxTxBytes` to `MaxTxSize`. | | pkg/appconsts/versioned_consts.go | Renamed function `MaxTxBytes` to `MaxTxSize`. | | pkg/appconsts/versioned_consts_test.go| Updated test cases to use `MaxTxSize` instead of `MaxTxBytes`. | | specs/src/ante_handler_v3.md | Updated documentation to reflect the change from `MaxTxBytes` to `MaxTxSize`. | ## Possibly related PRs - **#3909**: This PR introduces a new `MaxTxSizeDecorator` that enforces transaction size limits, directly related to the changes made in the `MaxTxSizeDecorator` and `AnteHandle` method in the main PR. ## Suggested labels `WS: Maintenance 🔧`, `optimization` ## Suggested reviewers - rootulp - evan-forbes - liamsi

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.