celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

Stop requiring `TestAppUpgradeV3` produce enough blocks to hit the DefaultUpgradeHeightDelay #3978

Open evan-forbes opened 1 month ago

evan-forbes commented 1 month ago

https://github.com/celestiaorg/celestia-app/blob/899ad7c56f62560a5666a604606f550ae1804cb3/app/test/upgrade_test.go#L106-L124

we're currently requiring a test to produce >50,400 block to pass, in order to prevent flakes in the race detector and simply to reduce the amount of time required for this test to pass, we should reduce the number of blocks that this has to take. This could be via build flags, or configuring the testapp specifically to not use the same constant.