coderabbitai[bot]
commented
1 week ago 📝 Walkthrough
## Walkthrough The pull request primarily updates the import paths for the `minfee` package across multiple files, changing from a versioned path (`github.com/celestiaorg/celestia-app/v3/x/minfee`) to a non-versioned path (`github.com/celestiaorg/celestia-app/x/minfee`). Additionally, it introduces new constants and functions in the `x/minfee` package, modifies test cases to align with these changes, and updates the `go.mod` file to reflect new dependencies and configurations. The overall functionality and logic of the application remain unchanged. ## Changes | File | Change Summary | |-------------------------------------|------------------------------------------------------------------------------------------------------------------| | app/ante/fee_checker.go | Updated import path for `minfee` package. No logic changes. | | app/ante/min_fee_test.go | Updated import path for `minfee`. Modified `TestValidateTxFee` to use `minfee.DefaultNetworkMinGasPrice`. | | app/app.go | Updated import path for `minfee` package. No logic changes. | | app/app_test.go | Updated import path for `minfee`. No logic changes. | | app/modules.go | Updated import path for `minfee`. No logic changes. | | app/test/query_test.go | Changed package name from `minfee_test` to `app_test`. Updated import path and assertions in `TestQueryNetworkMinGasPrice`. | | app/test/std_sdk_test.go | Updated import path for `minfee`. Modified assertions in `TestGRPCQueries`. | | app/test/upgrade_test.go | Changed import from relative to absolute for `minfee`. Updated `TestAppUpgradeV2` to use `minfee.DefaultNetworkMinGasPriceAsDec()`. | | go.mod | Added new dependency for `minfee`. Updated versions for other dependencies. Added replace directive for `minfee`. | | pkg/appconsts/initial_consts.go | Deprecated `DefaultNetworkMinGasPrice`, suggesting import from `x/minfee`. | | pkg/user/tx_client.go | Updated import path for `minfee`. No logic changes. | | test/tokenfilter/setup.go | Updated import path for `minfee`. No logic changes. | | x/minfee/constants.go | Introduced `DefaultNetworkMinGasPrice` constant and `DefaultNetworkMinGasPriceAsDec()` function. | | x/minfee/constants_test.go | Added `TestDefaultNetworkMinGasPriceAsDec` to validate the new constant's behavior. | | x/minfee/genesis.go | Updated `DefaultGenesis` to use `DefaultNetworkMinGasPriceAsDec()` for `NetworkMinGasPrice`. | | x/minfee/go.mod | Created new module for `minfee` with dependencies and replace directives. | | x/minfee/module_test.go | Updated import path for `minfee`. No logic changes. | | x/minfee/params.go | Removed `DefaultNetworkMinGasPrice` and associated initialization logic. | | x/paramfilter/test/gov_params_test.go | Updated import path for `minfeetypes`. No logic changes. | ## Possibly related PRs - **#3450**: Modifies the `minfee` registration in `app/ante/min_fee_test.go`, directly related to the import path changes. - **#3575**: Renames the global minimum gas price to network minimum gas price, relevant to the changes in the main PR. - **#3661**: Updates specifications for version 2, potentially relating to transaction fee validation logic. - **#3735**: Refactors gas scheduler variables, connecting to transaction fee validation changes. - **#3882**: Introduces versioned timeout settings, which could relate to transaction fee validation logic. - **#3910**: Implements an end-to-end upgrade test for version 3, possibly involving transaction fee validation. - **#3980**: Modifies upgrade height delay logic, relevant to transaction fee validation. - **#4008**: Addresses upgrade delay functionality, critical for transaction fee validation during upgrades. ## Suggested labels `enhancement`, `WS: Maintenance 🔧` ## Suggested reviewers - evan-forbes - staheri14 - cmwaters - ninabarbakadzeThank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
evan-forbes
Motivation
As part of the refactor to a multiplexed app, we want a mechanism to avoid importing state machine modules (e.g.
x/minfee) once per state machine version. We want this because each time a state machine module is imported by the multiplexer, it registers proto types in the proto registry and interfaces in the Cosmos SDK interface registry. When we import the same state machine module more than once, we hit duplicate proto registry errors (same for Cosmos SDK interface registry).This PR is the first of many that spin out a distinct Go module per state machine module. Expect subsequent PRs for
x/blob,x/signal, etc.Note: if we didn't do this for the multiplexed app, it is likely that we would do this as part of an update to new Cosmos SDK versions. For example Cosmos SDK v0.52.x spun out Go modules for all the state machine modules.
Note: the diff of
x/minfeefrom v2.x to main is minimal (seegit diff v2.x..main -- x/minfee/) so I choose to do this on main. We'll need to backport this to v2.x as well.Testing
I did this on my fork and verified that we can:
Ref: