celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

chore: bump txsim version #4009

Closed mojtaba-esk closed 3 weeks ago

mojtaba-esk commented 3 weeks ago

There was an issue with the txsim that did not allow the E2ESimple test to run; consequently, ongoing celestia-node e2e tests fail.

/opt/entrypoint.sh: illegal option -- -
Invalid option:

Thanks to @smuu for his investigation to discover the root cause of the issue and to propose a solution that bumps the txsim version to make it work.

This PR proposes a version bump for txsim docker image in the e2e test.

coderabbitai[bot] commented 3 weeks ago
📝 Walkthrough ## Walkthrough The changes in this pull request involve updating the `TxsimVersion` constant in the `test/e2e/testnet/defaults.go` file. The value has been changed from `"pr-3541"` to `"8e573bb"`, with no other modifications made to the file or its structure. ## Changes | File | Change Summary | |--------------------------------------|-------------------------------------------------------| | test/e2e/testnet/defaults.go | Updated `TxsimVersion` from `"pr-3541"` to `"8e573bb"` | ## Possibly related issues - **celestiaorg/celestia-app#3947**: The issue discusses the need to remove a hardcoded Docker image version in a test, which relates to the versioning of `txsim` in the context of e2e tests. ## Possibly related PRs - **#3541**: This PR also modifies the `TxsimVersion` constant in the same file, indicating a direct relationship to the current changes. ## Suggested labels `enhancement`, `WS: Big Blonks 🔭` ## Suggested reviewers - cmwaters - rootulp

📜 Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between b991437105b897df1ed22356a5000f27fdab9a94 and 7d5f30d8d0f1dc118589a6481686d62e6cc41cde.
📒 Files selected for processing (1) * test/e2e/testnet/defaults.go (1 hunks)
🔇 Additional comments (1)
test/e2e/testnet/defaults.go (1)
`13-13`: **Verify the referenced txsim commit exists** The version change from "pr-3541" to "8e573bb" appears to address the entrypoint.sh script issues mentioned in the PR objectives. However, let's verify that this commit hash exists and is stable.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
evan-forbes commented 3 weeks ago

wow, thanks! sorry we missed this