search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

docs: draft ADR 023 #4034

Open rootulp opened 1 week ago

rootulp commented 1 week ago

Related to https://github.com/celestiaorg/celestia-app/pull/3729

rootulp commented 1 week ago

I'm not sure what to add here. My next step is to repeat module extraction for the remaining state machine modules so maybe we can potentially merge this as-is and then I can update it when I resume work on the prototype after all the state machine modules are extracted.

rootulp commented 6 days ago

Two variants on the current design proposed by @tac0turtle:

  1. Extract old state machines to run out of process so they aren't contained in the latest app binary

    Screenshot 2024-11-15 at 14 53 30

  2. Extract celestia-core to run out of process from the multiplexer

    Screenshot 2024-11-15 at 14 55 29

rootulp commented 6 days ago

this misses details on:

Agreed, added those questions to the ADR.

It would also be nice if your diagram showed a venn diagram of modules i.e. v3 can have overlap but also a different subset of modules.

Added a module unique to v4.

Also in practice v1, v2 and v3 will probably be rolled together as a single state machine and v4 will be a different set of dependencies etc.

Good call, updated the diagram to v3 and v4.