search

celestiaorg / celestia-app

Celestia consensus node
https://celestiaorg.github.io/celestia-app/
Apache License 2.0
345 stars 292 forks source link

fix: improve single-node.sh #4041

Open rootulp opened 1 day ago

rootulp commented 1 day ago

Fixes a few issues I discovered with single-node.sh

  1. single-node.sh previously created a genesis file with appVersion: 3 so even though it attempted to upgrade from v1 -> v2, that step doesn't make any sense because the node was already on v3. This PR fixes the issue by modifying the genesis file to use appVersion: 1
  2. Add a few more logs
  3. Add a new script: upgrade-to-v3.sh that can be invoked to upgrade the single node from v2 -> v3. After running the command, the user will see
An upgrade is pending to app version 3 at height 50406.

FLUPs

  1. Modify single-node.sh to override the upgrade height delay and instead upgrade from v2 -> v3 instantly.
coderabbitai[bot] commented 1 day ago
📝 Walkthrough
📝 Walkthrough ## Walkthrough The changes in this pull request involve modifications to the versioning and upgrade logic of the Celestia application. Key updates include enhanced logging for version upgrades in the `EndBlocker` and `BeginBlocker` methods, improvements to ensure strictly increasing version changes, and the introduction of a new script to facilitate upgrades from version 2 to version 3. Additionally, the `single-node.sh` script has been updated to improve the robustness of version setting in the genesis configuration. ## Changes | File | Change Summary | |----------------------------|---------------------------------------------------------------------------------------------------------| | app/app.go | Updated `EndBlocker` and `BeginBlocker` methods to add logging for version upgrades; refined upgrade logic to prevent downgrades. | | scripts/single-node.sh | Enhanced the script to use regex for setting app version in genesis config; improved configuration modification for `config.toml`. | | scripts/upgrade-to-v3.sh | New script created to automate the upgrade process from version 2 to version 3, including necessary environment variable setups and command submissions. | ## Possibly related PRs - **#3469**: Modifies the `single-node.sh` script to start with app version 1 and upgrade to version 2, directly related to versioning changes. - **#3634**: Adds logging for the upgrade from version 1 to version 2 in the `BeginBlocker` function, aligning with logging enhancements in this PR. - **#3846**: Refactors the `InitChain` function to improve version handling, relevant to the changes in this PR. - **#3882**: Introduces versioned timeout settings based on application version, connecting to versioning and upgrade logic. - **#3910**: Implements an end-to-end upgrade test for version 3, directly related to upgrade logic discussed in this PR. - **#3962**: Updates application version parameter to reflect version 3, relevant to versioning changes in this PR. - **#4022**: Adds a script to configure version 3, related to overall upgrade process and version management. ## Suggested labels `enhancement`, `WS: V3 3️⃣`, `required` ## Suggested reviewers - evan-forbes - cmwaters - staheri14 - ninabarbakadze
📜 Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
📥 Commits Reviewing files that changed from the base of the PR and between 586e7f72306313d2389ffbea7d801eed5d842dd2 and 434f6ba3a99bbd18cf1a1be483b6c66906bd8ebb.
📒 Files selected for processing (1) * `app/app.go` (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1) * app/app.go

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.