celestiaorg / celestia-app

PoS application for the consensus portion of the Celestia network. Built using celestia-core (fork of CometBFT) and the cosmos-sdk
https://celestia.org
Apache License 2.0
330 stars 272 forks source link

Repo and command-line tool name #54

Closed liamsi closed 1 year ago

liamsi commented 3 years ago

Currently, the binary that runs lazyledger is called lazyledger-appd. We should probably rename this to lazyledger or lazyledgerd?

Also, the repo name could just be lazyledger or lazyledger-rsm (replicated state machine) or some other name we should settle on.

There was also the suggestion to rename the tendermint binaries in lazyledger-core. IMO, their name can just stay the same. The consensus is in fact tendermint consensus and the user-facing binaries are in here.

Also, another name to consider is the one chosen for modules (currently there is only one): https://github.com/lazyledger/lazyledger-app/tree/master/x/lazyledgerapp

cc @musalbas @adlerjohn

adlerjohn commented 3 years ago

I like the d at the end fwiw

tac0turtle commented 2 years ago

def a fan of naming the repo merely Celestia and the executable celestiad

musalbas commented 2 years ago

I think celestia-node should be the real celestiad

tac0turtle commented 2 years ago

makes sense. is there a plan to merge both executables?

liamsi commented 2 years ago

I think celestia-node should be the real celestiad

And what should we call celestia-app then? @musalbas

is there a plan to merge both executables?

maybe: https://github.com/celestiaorg/celestia-node/issues/275

tac0turtle commented 2 years ago

keeping them as two different repos but one executable is possible. It would be this pr https://github.com/celestiaorg/celestia-app/pull/177 in the other repo then the app commands could be under celestiad app and celestiad node for node. Would simplify having multiple locations to download things.

liamsi commented 2 years ago

cc @Wondertan @renaynay

renaynay commented 2 years ago

can't we call celestia app just app? 100% let's keep the repos separate, but fine with making it one executable in the future.