search

celestiaorg / celestia-core

A fork of CometBFT
Apache License 2.0
481 stars 264 forks source link

TestTxPool_ConcurrentlyAddingTx is flaky #1383

Closed staheri14 closed 4 days ago

staheri14 commented 3 months ago

Problem

The TestTxPool_ConcurrentlyAddingTx appears to be flaky. Please see https://github.com/celestiaorg/celestia-core/actions/runs/9419666295/job/25949967898?pr=1379 

--- FAIL: TestTxPool_ConcurrentlyAddingTx (0.00s)
    pool_test.go:737: 
            Error Trace:    /home/runner/work/celestia-core/celestia-core/mempool/cat/pool_test.go:737
            Error:          Not equal: 
                            expected: 9
                            actual  : 6
            Test:           TestTxPool_ConcurrentlyAddingTx

Re-running the jobs make it pass, so confirming the flakiness.

Acceptance Criteria

Investigating the root cause of flakiness and making necessary modifications to resolve it.