celestiaorg / celestia-core

Celestia node software based on Tendermint.
https://celestia.org/
Apache License 2.0
470 stars 244 forks source link

Compare duplicate messages with copy in receive #1386

Open evan-forbes opened 2 weeks ago

evan-forbes commented 2 weeks ago

Occasionally, we see duplicate messages from the same peer. It could be caused by the issue here. This is easy to test, where we simply add a copy and compare and contrast the duplicate message received.

https://github.com/cometbft/cometbft/issues/3237

AC

This issue can be closed by copying instead of reallocating where we receive messages, and then posting the comparison here. If the issue is fixed and doesn't have noticeable draw backs, then we can open a different issue to actually add it.