search

celestiaorg / celestia-core

A fork of CometBFT
Apache License 2.0
489 stars 269 forks source link

Considering removing validation of timeout commit and timeout propose from ValidateBasic() after implementing versioned timeouts #1517

Open staheri14 opened 1 month ago

staheri14 commented 1 month ago

After introducing versioned timeouts, it may be decided to remove the TimeoutCommit and TimeoutPropose fields from the configs. If this happens, then there is no need to validate them in the ConsensusConfig.ValidateBasic(). This issue serves as a reminder to proceed with this change, if that decision has been made.

rootulp commented 1 month ago

it may be decided to remove the TimeoutCommit and TimeoutPropose fields from the configs

I think we need to keep these in the celestia-app v3 binary because the config values should be used until the app version upgrades from 2 -> 3. So this issue can only be done in celestia-app v4.

Another idea: removing those two fields from the config may be considered breaking so proposal to keep them in config but document that they have no impact in >= v4 binary.