Minor followups on adr 002 - Githubissues

celestiaorg / celestia-core

A fork of CometBFT

Apache License 2.0

489 stars 269 forks source link

Minor followups on adr 002 #179

Closed liamsi closed 3 years ago

liamsi commented 3 years ago

We've decided to merge the ADR 002 (#170) and update it to keep in sync with the implementation in various PRs.

There are few things that I'd like to capture here so they don't get lost:

[ ] fully clarify https://github.com/lazyledger/lazyledger-core/pull/170#discussion_r585367511
[ ] clarify "asyncness" of API in ADR: https://github.com/lazyledger/lazyledger-core/pull/170#discussion_r585643272
[ ] make sure link to adr 001 works: https://github.com/lazyledger/lazyledger-core/pull/170#discussion_r586462163
[ ] clarify sample domain: https://github.com/lazyledger/lazyledger-core/pull/170#discussion_r585739573
[ ] update Status from Proposed to Implemented as soon as the bulk of the implementation was done (before merging the last PR that achieves this)

liamsi commented 3 years ago

The code this ADR is about should either be moved into a separate repo or simply be moved into https://github.com/celestiaorg/celestia-node. Hence, closing.

ref: https://github.com/celestiaorg/celestia-node/issues/1