consider removing LastResultHash and EvidenceHash

celestiaorg / celestia-core

A fork of CometBFT

Apache License 2.0

489 stars 269 forks source link

Closed liamsi closed 1 year ago

liamsi commented 3 years ago

Evidence is already part of Block.Data. Not sure about the implications for both hashes yet.

[ ] better understand the implications of this change and document in an ADR (e.g. do light-clients use evidence hash?)
[ ] execute the changes

ref: #66

rootulp commented 1 year ago

Evidence is already part of Block.Data.

This was reverted in https://github.com/celestiaorg/celestia-core/issues/894 so this issue no longer seems relevant.