search

celestiaorg / celestia-core

A fork of CometBFT
Apache License 2.0
489 stars 269 forks source link

Use `sha256-simd` instead of native Golang implementation #272

Closed Wondertan closed 1 year ago

Wondertan commented 3 years ago

Having a computation speed-up through easy to integrate lib for such a widely used primitive is awesome.

liamsi commented 3 years ago

ref: https://github.com/lazyledger/lazyledger-core/pull/351

rootulp commented 1 year ago

Closing this as won't do b/c a goal of this repo is to minimize the diff between celestia-core and upstream cometBFT. Please re-open if this should still be considered.

evan-forbes commented 1 year ago

also fwiw the speed up between the standard library and simd should be significantly smaller after go 1.21