search

celestiaorg / celestia-core

A fork of CometBFT
Apache License 2.0
491 stars 270 forks source link

Optimize RetrieveBlockData #278

Closed liamsi closed 3 years ago

liamsi commented 3 years ago

Currently, we spin up a go-rountine per row/colum leaf that we want to sample in RetrieveBlockData. It might be more efficient (and more readable) to use the IPFS api for this. Original discussion: https://github.com/lazyledger/lazyledger-core/pull/232#discussion_r609417214

Also related: #357

Wondertan commented 3 years ago

@liamsi, can we close this in favour of https://github.com/celestiaorg/lazyledger-core/issues/429

liamsi commented 3 years ago

OK, there is certainly more context in #429 already.