search

celestiaorg / celestia-core

A fork of CometBFT
Apache License 2.0
483 stars 263 forks source link

Create ABCI++ branch with celestia specific changes #623

Closed evan-forbes closed 2 years ago

evan-forbes commented 2 years ago

We should create a release branch that incorporates all of the necessary celestia specific changes with all of the changes made so far with upstream's ABCI++ branch

liamsi commented 2 years ago

What is the status/purpose of this? If we want to diff between this and upstream, we can do so from our main branch and look at the abci++ changes manually?

evan-forbes commented 2 years ago

I think was meant to be closed by #631

Closes https://github.com/celestiaorg/celestia-core/issues/623

but the format was wrong so the github hook didn't pick up on it. Any future changes related to ABCI++ should be incorporated via cherry-picking changes from an old celestia release branch onto a branch based on some stable/release branch of tendermint