Fix data race for `env` in tendermint/tendermint

celestiaorg / celestia-core

A fork of CometBFT

Apache License 2.0

481 stars 264 forks source link

Fix data race for `env` in tendermint/tendermint #882

Open rootulp opened 1 year ago

rootulp commented 1 year ago

Context

https://github.com/celestiaorg/celestia-core/pull/869 introduces a short-term fix to prevent data races when accessing a shared global variable: env.

Problem

The above PR bloats the difference between tendermint/tendermint and celestia-core which causes additional friction when pulling upstream changes into this fork.

Proposal

Make a similar fix upstream in tendermint/tendermint and pull those changes into this fork

evan-forbes commented 7 months ago

This might be handled in a future version of Comet, in which case we could close this issue