search

celestiaorg / celestia-node

Celestia Data Availability Nodes
Apache License 2.0
935 stars 931 forks source link

eds: Flaky TestFraudProofValidation #2457

Open Wondertan opened 1 year ago

Wondertan commented 1 year ago 
--- FAIL: TestFraudProofValidation (15.64s)
    --- FAIL: TestFraudProofValidation/ods_size:128 (10.38s)
        retriever_test.go:143: 
                Error Trace:    /home/runner/work/celestia-node/celestia-node/share/eds/retriever_test.go:143
                Error:          Should be true
                Test:           TestFraudProofValidation/ods_size:128
FAIL
FAIL    github.com/celestiaorg/celestia-node/share/eds  50.668s

Fails pretty often with race flag on

vgonkivs commented 1 year ago

My first thoughts were: as we are creating a broken eds by swapping share[0] and share[1] - at some point these shares are equal and reconstruction finishes successfully. But adding a special condition that ensures the difference between them, shows that shares differ. That means, that smth happens on the reconstruction level. @walldiss, have you faced with similar rsmt2d issues before?