search

celestiaorg / celestia-node

Celestia Data Availability Nodes
Apache License 2.0
929 stars 925 forks source link

fix(da): Flaky Commit and Verify tests #3157

Open distractedm1nd opened 9 months ago

distractedm1nd commented 9 months ago

The Commit and Verify tests in da_test.go are flaky and require investigation. They are currently skipped with t.Skip()

distractedm1nd commented 9 months ago

Another flake. Assuming header WaitForHeight needs to be called, since we are using two nodes for requests they may be out of sync with each other

--- FAIL: TestDaModule (6.12s)
    --- FAIL: TestDaModule/GetIDs (0.00s)
        da_test.go:106: 
                Error Trace:    /home/runner/work/celestia-node/celestia-node/nodebuilder/tests/da_test.go:106
                                            /home/runner/work/celestia-node/celestia-node/nodebuilder/tests/da_test.go:141
                Error:          Received unexpected error:
                                header: given height is from the future: networkHeight: 1, requestedHeight: 6
                Test:           TestDaModule/GetIDs
    full_node.go:181: tearing down testnode
toxicfuz commented 9 months ago

Since the error suggests a height synchronization problem, stating that the given height (networkHeight: 1) conflicts with the expected height (requestedHeight: 6), is there a way to mock expected inputs to identify other TestDaModule bugs?

Wondertan commented 9 months ago

There is definitely a way to mock flaky component out. Would you want to help out with this?