search

celestiaorg / celestia-node

Celestia Data Availability Nodes
Apache License 2.0
922 stars 922 forks source link

Investigate the implications of the client choosing whether to sample from row or column #3198

Closed musalbas closed 7 months ago

musalbas commented 3 years ago

In the fraud proofs paper, the client picks the (x, y) co-ordinates, but the node decides whether to return a response from the row or column root.

In the current implementation, the client also decides whether the response should be from a row or column root.

We should consider the security implications to this if, any.

adlerjohn commented 3 years ago

Also related: https://github.com/lazyledger/lazyledger-specs/issues/110#issuecomment-818786351

Wondertan commented 7 months ago

We made make it secure, but its inefficient. Really, the client shouldn't care how their shares are proved. As long as they are proven, dasing works. This will be changed to the way its described in the paper via #2971, so closing this investigation issue.