search

celestiaorg / celestia-node

Celestia Data Availability Nodes
Apache License 2.0
912 stars 903 forks source link

improvement(state/core_access): remove defaultSignerAccount and defaultSignerAddress in favor and use app.ClientTx instead #3515

Open vgonkivs opened 1 month ago

vgonkivs commented 1 month ago

We can get rid of these two fields inside core_access and ru-use clientTx. Since the node's version of the app contains a small bug in handling DefaultAccountAddress(), it should be done after https://github.com/celestiaorg/celestia-app/pull/3597 is included in app release.

Lets also use only user.WithDefaultAccount(keyName) in SetupTxClient

MukulKolpe commented 4 weeks ago

Hey @vgonkivs, can I work on this issue?

vgonkivs commented 4 weeks ago

Hello, @MukulKolpe. These changes haven't been released yet. Also this issue is blocked by https://github.com/celestiaorg/celestia-node/pull/3349

vgonkivs commented 1 week ago

Hello @MukulKolpe. Do you still want to work on this issue?

MukulKolpe commented 1 week ago

Yes, I am still interested in working on this issue.

vgonkivs commented 1 week ago

Awesome. Thank you so much. Do not hesitate to ask any questions.